Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: properly convert .gypi in install.py #21850

Closed
wants to merge 1 commit into from
Closed

tools: properly convert .gypi in install.py #21850

wants to merge 1 commit into from

Conversation

hashseed
Copy link
Member

It was breaking during install when .gypi strings had quotes in
them. e.g.: 'foo': 'bar="baz"'

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@mi-ac @hashseed
tools: properly convert .gypi in install.py
0247f6c 
It was breaking during install when .gypi strings had quotes in
them. e.g.: 'foo': 'bar="baz"'
@nodejs-github-bot
Copy link
Collaborator

@hashseed build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/292/pipeline

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Jul 17, 2018
@refack
Copy link
Contributor

refack commented Jul 18, 2018

CI run: https://ci.nodejs.org/job/node-test-pull-request/15919/
(Interesting to see as we have some python 2.6 in there)

@refack
Copy link
Contributor

refack commented Jul 18, 2018

/CC @nodejs/python @nodejs/build-files

@refack refack added the tools Issues and PRs related to the tools directory. label Jul 18, 2018
@hashseed
Copy link
Member Author

Landed as 5e5ffc8.

@hashseed hashseed closed this Jul 19, 2018
targos referenced this pull request Jul 20, 2018
@mi-ac @hashseed
tools: properly convert .gypi in install.py
5e5ffc8 
It was breaking during install when .gypi strings had quotes in
them. e.g.: 'foo': 'bar="baz"'
@refack refack mentioned this pull request Aug 1, 2018
Merged
This was referenced Aug 1, 2018
Closed
Closed
Closed
Closed
Closed
Closed
@hashseed hashseed deleted the gypi_parse branch November 20, 2018 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsnek devsnek devsnek approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

@bnoordhuis bnoordhuis Awaiting requested review from bnoordhuis

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@hashseed @nodejs-github-bot @refack @jasnell @thefourtheye @addaleax @cjihrig @richardlau @devsnek @mi-ac